Disallow arithmetic, comparison and bitwise operations on number supertypes #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
commented
Jan 14, 2022
| leftType, rightType Type, | ||
| leftIsInvalid, rightIsInvalid, anyInvalid bool, | ||
| anyInvalid bool, |
There was a problem hiding this comment.
Cleaning up some unused params
| @@ -837,252 +835,3 @@ func TestInterpretSaturatedArithmeticFunctions(t *testing.T) { | |||
| test(ty, "Divide", testCase.divide) | |||
| } | |||
| } | |||
|
|
|||
| func TestInterpretArithmeticOnSubTypes(t *testing.T) { | |||
There was a problem hiding this comment.
This test is no longer valid, as it will never reach the runtime
Comment on lines
-148
to
-151
| ast.OperationGreater, | ||
| ast.OperationGreaterEqual, | ||
| ast.OperationLess, | ||
| ast.OperationLessEqual, |
There was a problem hiding this comment.
Similarly, these tests (i.e: checking the runtime behavior for these operations) are no longer valid, since they don't reach runtime
Codecov Report
@@ Coverage Diff @@
## master #1360 +/- ##
==========================================
- Coverage 75.78% 73.03% -2.76%
==========================================
Files 280 279 -1
Lines 38779 38794 +15
==========================================
- Hits 29390 28333 -1057
- Misses 8039 9023 +984
- Partials 1350 1438 +88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 86d42e3 Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SupunS
added
the
Language Breaking Change
Co-authored-by: Bastian Müller <[email protected]>
…d future missing functions
|
Took the liberty to quickly fix the PR |
14 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/dapperlabs/cadence-private-issues/issues/10
Description
This is a reference implementation for the changes proposed on FLIP: onflow/flow#729
masterbranchFiles changedin the Github PR explorer