Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links in callouts, linting #1359

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

alxflw
Copy link
Contributor

@alxflw alxflw commented Jan 14, 2022

Description

There is no issue for this but I saw the broken formatting on the page and submitted a quick fix.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Jan 14, 2022
@turbolent turbolent added the Documentation Improvements or additions to documentation label Jan 14, 2022
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for cleaning this up! 👍

@codecov-commenter
Copy link

Codecov Report

Merging #1359 (4ee47d3) into master (95aea4a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   75.78%   75.78%   -0.01%     
==========================================
  Files         280      280              
  Lines       38779    38779              
==========================================
- Hits        29390    29389       -1     
- Misses       8039     8040       +1     
  Partials     1350     1350              
Flag Coverage Δ
unittests 75.78% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/simple_type.go 92.85% <0.00%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95aea4a...4ee47d3. Read the comment docs.

@alxflw
Copy link
Contributor Author

alxflw commented Jan 14, 2022

@joshuahannan the benchmark test is failing with:

Error: Resource not accessible by integration
Error: See this action's readme for details about this error

is that something that requires more attention? merging is blocked for me

@turbolent turbolent merged commit 86d42e3 into onflow:master Jan 14, 2022
@turbolent
Copy link
Member

@alxflw No, that error can be safely ignored. CI is benchmarking changes, and it does not seem to be available for PRs from contributors, but the PR only changes documentation, so it's all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants