Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 02-hello-world.mdx #1357

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Update 02-hello-world.mdx #1357

merged 3 commits into from
Jan 28, 2022

Conversation

kon-foo
Copy link
Contributor

@kon-foo kon-foo commented Jan 12, 2022

Description

I changed the paths to match the paths used in the playground.
I changed let helloReference = capability.borrow() to let helloReference = capability!.borrow() to match the playground and prevent the error unknown member error.
I corrected "and the storage will longer contain an object under the given path." to "and the storage will no longer contain an object under the given path."


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Corrected the paths to match the paths used in the playground.
@joshuahannan
Copy link
Member

Thanks for pointing this out, but the docs here are actually correct! The path should be HelloAssetTutorial. I'll update the playground code. Can you revert those changes and only include the non-path related ones?

@turbolent turbolent added the Documentation Improvements or additions to documentation label Jan 12, 2022
@kon-foo
Copy link
Contributor Author

kon-foo commented Jan 15, 2022

Sorry, I'm not good with git or github. How do I edit my commit/ add another commit to this pull request?

@joshuahannan
Copy link
Member

You can edit the code in your local branch and commit and push the changes again and it should update the PR. Does that make sense?

@turbolent
Copy link
Member

@joshuahannan Reverted the path changes. Do the rest of the changes look correct?

@turbolent turbolent merged commit 34ecf9c into onflow:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants