Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.20] Fix IsContainerType for CompositeType and InterfaceType #1355

Merged
merged 2 commits into from
Jan 11, 2022
Merged

[0.20] Fix IsContainerType for CompositeType and InterfaceType #1355

merged 2 commits into from
Jan 11, 2022

Conversation

turbolent
Copy link
Member

Description

Port of dapperlabs/cadence-internal#43 to v0.20 branch

#1339 was accidentally against master

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from SupunS as a code owner January 11, 2022 23:23
@turbolent turbolent self-assigned this Jan 11, 2022
@turbolent turbolent changed the title fix IsContainerType for CompositeType and InterfaceType [0.20] Fix IsContainerType for CompositeType and InterfaceType Jan 11, 2022
@turbolent turbolent merged commit b92e824 into v0.20 Jan 11, 2022
@turbolent turbolent deleted the supun/port-internal-43 branch January 11, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

Assignees

@turbolent turbolent

Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS