trying to add indexOf to array #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjartek
requested review from
joshuahannan,
SupunS and
turbolent
as code owners
turbolent
reviewed
Jan 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
==========================================
- Coverage 75.81% 72.65% -3.17%
==========================================
Files 279 288 +9
Lines 38780 39301 +521
==========================================
- Hits 29402 28555 -847
- Misses 8016 9257 +1241
- Partials 1362 1489 +127
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
turbolent
reviewed
Jan 13, 2022
turbolent
reviewed
Jan 13, 2022
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
turbolent
approved these changes
Jan 13, 2022
Comment on lines
+770
to
+783
| func TestCheckArrayIndexOfNonEquatableValueArray(t *testing.T) { | ||
|
|
||
| t.Parallel() | ||
|
|
||
| _, err := ParseAndCheck(t, ` | ||
| fun test(): Int? { | ||
| let x = [[1, 2], [3]] | ||
| return x.firstIndex(of: [3]) | ||
| } | ||
| `) | ||
|
|
||
| errs := ExpectCheckerErrors(t, err, 1) | ||
| assert.IsType(t, &sema.NotEquatableTypeError{}, errs[0]) | ||
| } |
|
@SupunS @dsainati1 when you get a change, could you please have a second look? Thank you! |
SupunS
approved these changes
Feb 23, 2022
Co-authored-by: Supun Setunga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1276
Description
If you want to remove an element from a cadence array right now you have to use loops in cadence. This is inneficient.
This PR implements the
indexOfmethod that in combination with remove can do that.masterbranchFiles changedin the Github PR explorer