Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject invalid access modifiers #1347

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

turbolent
Copy link
Member

Closes dapperlabs/cadence-private-issues#16


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from SupunS as a code owner January 10, 2022 22:49
@turbolent turbolent self-assigned this Jan 10, 2022
@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit b180983
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeFungibleTokenTransfer-21.88ms ±23%1.76ms ±24%~(p=0.259 n=7+7)
RuntimeResourceDictionaryValues-220.6ms ± 4%20.9ms ± 4%~(p=0.383 n=7+7)
ParseInfix-214.6µs ± 8%14.3µs ± 1%~(p=0.432 n=7+5)
ParseArray-218.9ms ± 3%18.7ms ± 5%~(p=0.534 n=6+7)
ParseDeploy/byte_array-229.7ms ± 2%29.0ms ± 5%~(p=0.181 n=6+7)
ParseDeploy/decode_hex-21.67ms ± 4%1.70ms ± 5%~(p=0.456 n=7+7)
QualifiedIdentifierCreation/One_level-23.93ns ± 3%3.95ns ± 3%~(p=0.731 n=6+7)
QualifiedIdentifierCreation/Three_levels-2202ns ± 4%205ns ± 3%~(p=0.132 n=6+6)
ContractInterfaceFungibleToken-262.3µs ± 4%61.9µs ± 3%~(p=0.445 n=6+7)
CheckContractInterfaceFungibleTokenConformance-2228µs ±15%216µs ± 4%~(p=0.165 n=7+7)
NewInterpreter/new_interpreter-21.51µs ± 3%1.54µs ± 7%~(p=0.534 n=6+7)
NewInterpreter/new_sub-interpreter-23.02µs ± 3%3.02µs ± 8%~(p=0.534 n=6+7)
InterpretRecursionFib-23.42ms ± 3%3.45ms ± 3%~(p=0.445 n=6+7)
ParseFungibleToken-2292µs ± 5%281µs ± 5%−3.90%(p=0.038 n=7+7)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2273kB ± 0%273kB ± 0%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.902 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
ContractInterfaceFungibleToken-226.5kB ± 0%26.5kB ± 0%~(p=1.000 n=7+7)
CheckContractInterfaceFungibleTokenConformance-265.7kB ± 0%65.7kB ± 0%~(p=1.000 n=7+7)
NewInterpreter/new_interpreter-2720B ± 0%720B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.18kB ± 0%1.18kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.706 n=7+7)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.085 n=6+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
ContractInterfaceFungibleToken-2457 ± 0%457 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
NewInterpreter/new_interpreter-211.0 ± 0%11.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-236.0 ± 0%36.0 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
 

@turbolent turbolent merged commit d96efb8 into master Jan 12, 2022
@turbolent turbolent deleted the bastian/reject-invalid-access-modifiers branch January 12, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants