Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resource owner section to resources page #1346

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

turbolent
Copy link
Member

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the Documentation Improvements or additions to documentation label Jan 7, 2022
@turbolent turbolent self-assigned this Jan 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1346 (ce67ee1) into master (b07c80c) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
+ Coverage   75.70%   75.75%   +0.05%     
==========================================
  Files         280      280              
  Lines       38585    38712     +127     
==========================================
+ Hits        29211    29327     +116     
- Misses       8028     8038      +10     
- Partials     1346     1347       +1     
Flag Coverage Δ
unittests 75.75% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/errors.go 20.71% <0.00%> (-1.43%) ⬇️
runtime/sema/type.go 88.45% <0.00%> (+0.14%) ⬆️
runtime/interpreter/value.go 71.33% <0.00%> (+0.32%) ⬆️
runtime/sema/simple_type.go 96.42% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07c80c...ce67ee1. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 7218aac
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
NewInterpreter/new_interpreter-21.19µs ± 1%1.20µs ± 1%+0.96%(p=0.037 n=6+7)
RuntimeResourceDictionaryValues-216.6ms ± 4%16.6ms ± 5%~(p=0.805 n=7+7)
RuntimeFungibleTokenTransfer-21.36ms ±23%1.42ms ±20%~(p=0.620 n=7+7)
ParseInfix-211.1µs ± 1%11.2µs ± 2%~(p=0.945 n=6+7)
ParseArray-219.0ms ± 7%18.2ms ± 7%~(p=0.259 n=7+7)
ParseDeploy/byte_array-230.0ms ± 5%30.2ms ±13%~(p=0.805 n=7+7)
ParseFungibleToken-2214µs ± 1%213µs ± 1%~(p=0.534 n=6+7)
QualifiedIdentifierCreation/One_level-23.20ns ± 0%3.19ns ± 1%~(p=0.102 n=7+7)
QualifiedIdentifierCreation/Three_levels-2164ns ± 2%166ns ± 3%~(p=0.209 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2157µs ± 1%157µs ± 2%~(p=1.000 n=7+7)
ContractInterfaceFungibleToken-247.4µs ± 1%47.1µs ± 1%~(p=0.138 n=7+6)
NewInterpreter/new_sub-interpreter-22.38µs ± 1%2.40µs ± 1%~(p=0.091 n=6+7)
InterpretRecursionFib-22.80ms ± 6%2.72ms ± 2%~(p=0.181 n=7+6)
ParseDeploy/decode_hex-21.41ms ± 2%1.40ms ± 1%−0.90%(p=0.035 n=7+6)
 
alloc/opdelta
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.165 n=7+7)
RuntimeFungibleTokenTransfer-2273kB ± 0%273kB ± 0%~(p=0.445 n=6+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-265.7kB ± 0%65.7kB ± 0%~(all equal)
ContractInterfaceFungibleToken-226.5kB ± 0%26.5kB ± 0%~(p=1.000 n=7+7)
NewInterpreter/new_interpreter-2720B ± 0%720B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.18kB ± 0%1.18kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.385 n=7+6)
 
allocs/opdelta
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.418 n=7+7)
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%~(p=1.000 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2457 ± 0%457 ± 0%~(all equal)
NewInterpreter/new_interpreter-211.0 ± 0%11.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-236.0 ± 0%36.0 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
 

@turbolent turbolent merged commit f2e41ec into master Jan 10, 2022
@turbolent turbolent deleted the bastian/move-resource-owner-section branch January 10, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants