Fix resource loss analysis and definite initialization analysis #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only consider definite invalidations - fix tracking when break or continue statements occur
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
+ Coverage 75.57% 75.59% +0.02%
==========================================
Files 279 279
Lines 37813 37837 +24
==========================================
+ Hits 28578 28604 +26
+ Misses 7958 7957 -1
+ Partials 1277 1276 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 834f5f1 Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SupunS
reviewed
Jan 5, 2022
|
|
||
| assert.IsType(t, &sema.ResourceLossError{}, errs[0]) | ||
| assert.IsType(t, &sema.UnreachableStatementError{}, errs[1]) | ||
| assert.IsType(t, &sema.ResourceLossError{}, errs[2]) |
There was a problem hiding this comment.
Is this a potential duplicate error?
There was a problem hiding this comment.
Yes, there is now an additional error reported, but "over reporting" isn't a problem: The first resource loss error is reported by the resource loss check by the return statement, and the second is returned by the resource loss check at the end of the function. Both are correct and I don't think it is worth the effort to reduce over reporting
|
|
||
| assert.IsType(t, &sema.ResourceLossError{}, errs[0]) | ||
| assert.IsType(t, &sema.UnreachableStatementError{}, errs[1]) | ||
| assert.IsType(t, &sema.ResourceLossError{}, errs[2]) |
6 tasks
Co-authored-by: Supun Setunga <[email protected]>
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1325
Based heavily on #1329, thank you @SupunS 🙏
Investigating the issue I also discovered that the definite initialization analysis suffered from the same problem.
Description
masterbranchFiles changedin the Github PR explorer