-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safety checks for go casts in the interpreter #1331
Conversation
…interpreter_expression.go
Codecov Report
@@ Coverage Diff @@
## master #1331 +/- ##
==========================================
- Coverage 75.57% 75.30% -0.27%
==========================================
Files 279 279
Lines 37813 37934 +121
==========================================
- Hits 28578 28568 -10
- Misses 7958 8030 +72
- Partials 1277 1336 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 834f5f1 Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Co-authored-by: Bastian Müller <[email protected]>
Description
This adds more graceful go handling for some type assertions in the runtime/sema directory, which previously were unhandled. This should not result in any behavioral differences. Part of https://github.com/dapperlabs/cadence-private-issues/issues/4
master
branchFiles changed
in the Github PR explorer