-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support recursive supertype inferring for containers #1319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
==========================================
- Coverage 77.43% 75.58% -1.85%
==========================================
Files 279 279
Lines 36174 37869 +1695
==========================================
+ Hits 28010 28622 +612
- Misses 7071 7964 +893
- Partials 1093 1283 +190
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 834f5f1 Results
|
a280653
to
051bf15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exciting! Thanks for following up on this!
f41dc08
to
c650dbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 👏
return InvalidType | ||
} | ||
|
||
if !IsValidDictionaryKeyType(keySuperType) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes #1225
Description
This PR add $subject for arrays and dictionaries.
master
branchFiles changed
in the Github PR explorer