Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 02-hello-world.mdx #1297

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Update 02-hello-world.mdx #1297

merged 1 commit into from
Dec 8, 2021

Conversation

gnujoow
Copy link
Contributor

@gnujoow gnujoow commented Dec 6, 2021

Closes #???

Description

AS-IS
image

Suggested
image

Now, all of the public fields, types, and functions defined by that contract
are available within your transaction by using the `ContractName.member` syntax.

I suggest modifying the spacing in the code to better understand the explanation that follows the code.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

```
Now, all of the public fields, types, and functions defined by that contract
are available within your transaction by using the `ContractName.member` syntax.
```

I suggest modifying the spacing in the code to better understand the explanation that follows the code.
@joshuahannan
Copy link
Member

I'm a little bit confused by what you're suggesting here. Can you elaborate? Thanks! 😃

@gnujoow
Copy link
Contributor Author

gnujoow commented Dec 6, 2021

thanks for your comment @joshuahannan.

in real-world code, import package with spacing occurs syntax error. And in the following document says your transaction by using the ContractName.member syntax. So I think to make Contract Name into camelCase is easier to understand to javascript developers.

as is

// as is
import { Contract Name } from { Address }

// suggest
import { ContractName } from { Address }

Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH, I see! I looked at it a bunch of times before and didn't notice the difference, but I see now. This makes sense. Thank you!

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SupunS SupunS merged commit b245cad into onflow:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants