-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Server updates #1295
Language Server updates #1295
Conversation
5ab5da2
to
a759a95
Compare
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit a9ef2ce Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes with proposed changes look good!
Codecov Report
@@ Coverage Diff @@
## master #1295 +/- ##
==========================================
- Coverage 77.41% 77.39% -0.02%
==========================================
Files 279 279
Lines 36113 36048 -65
==========================================
- Hits 27956 27899 -57
+ Misses 7066 7062 -4
+ Partials 1091 1087 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@SupunS can you check why test is failing?.. |
@MaxStalker CI is failing because it checks that all generated files are checked in, which isn't the case on master. This isn't your fault, I'm fixing on master and will rerun CI for you |
…anguage-server-update-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go changes look fine to me. Also, already been reviewed by others with more contextual knowledge. 🎉
Closes #1294
Description
This PR will:
pragma
keywordmaster
branchFiles changed
in the Github PR explorer