Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm packages #1293

Merged
merged 6 commits into from
Dec 8, 2021
Merged

Fix npm packages #1293

merged 6 commits into from
Dec 8, 2021

Conversation

turbolent
Copy link
Member

Depends on #1292

  • Update the version numbers
  • Update go.js to Go 1.17.2 libexec/misc/wasm/wasm_exec.js

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the Chore label Dec 3, 2021
@turbolent turbolent requested a review from SupunS December 3, 2021 00:55
@turbolent turbolent self-assigned this Dec 3, 2021
Base automatically changed from bastian/merge-v0.20 to master December 8, 2021 13:16
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 893312c
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeResourceDictionaryValues-217.7ms ± 2%17.8ms ± 2%~(p=0.383 n=7+7)
RuntimeFungibleTokenTransfer-21.37ms ±23%1.53ms ±18%~(p=0.165 n=7+7)
ParseInfix-225.4µs ± 1%25.6µs ± 3%~(p=0.534 n=6+7)
ParseFungibleToken-2483µs ± 1%484µs ± 1%~(p=0.805 n=7+7)
ParseArray-224.0ms ± 1%23.9ms ± 2%~(p=0.902 n=7+7)
ParseDeploy/byte_array-236.0ms ± 1%36.2ms ± 1%~(p=0.295 n=6+7)
ParseDeploy/decode_hex-21.46ms ± 2%1.44ms ± 2%~(p=0.209 n=7+7)
QualifiedIdentifierCreation/One_level-23.22ns ± 0%3.22ns ± 0%~(p=0.978 n=7+6)
QualifiedIdentifierCreation/Three_levels-2165ns ± 2%167ns ± 4%~(p=0.259 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2160µs ± 3%159µs ± 2%~(p=0.902 n=7+7)
ContractInterfaceFungibleToken-248.6µs ± 4%49.0µs ± 3%~(p=0.366 n=7+6)
NewInterpreter/new_interpreter-21.20µs ± 1%1.21µs ± 2%~(p=0.420 n=6+6)
NewInterpreter/new_sub-interpreter-22.24µs ± 1%2.25µs ± 2%~(p=0.534 n=6+7)
InterpretRecursionFib-22.85ms ± 7%2.76ms ± 1%~(p=0.295 n=7+6)
 
alloc/opdelta
RuntimeResourceDictionaryValues-24.34MB ± 0%4.34MB ± 0%~(p=0.383 n=7+7)
RuntimeFungibleTokenTransfer-2238kB ± 0%238kB ± 0%~(p=0.383 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-265.7kB ± 0%65.7kB ± 0%~(p=1.000 n=7+7)
ContractInterfaceFungibleToken-226.5kB ± 0%26.5kB ± 0%~(all equal)
NewInterpreter/new_interpreter-2720B ± 0%720B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.11kB ± 0%1.11kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.318 n=5+7)
 
allocs/opdelta
RuntimeResourceDictionaryValues-2108k ± 0%108k ± 0%~(p=0.902 n=7+7)
RuntimeFungibleTokenTransfer-24.53k ± 0%4.53k ± 0%~(p=0.103 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2457 ± 0%457 ± 0%~(all equal)
NewInterpreter/new_interpreter-211.0 ± 0%11.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-232.0 ± 0%32.0 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
 

@turbolent turbolent merged commit a9920d3 into master Dec 8, 2021
@turbolent turbolent deleted the bastian/fix-npm-packages branch December 8, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants