Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable existing hints if linting is disabled #1275

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

turbolent
Copy link
Member

Depends on #1072

Description

Just like disabling the new hint in #1072, also disable the existing hints when linting is disabled (the default).


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Contributor

@dsainati1 dsainati1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense; I also don't think it makes sense to report hints when linting is not enabled.

Base automatically changed from supun/warn-cast-2 to master November 26, 2021 20:27
@codecov-commenter
Copy link

Codecov Report

Merging #1275 (8a51b83) into master (57b96c6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
- Coverage   77.21%   77.21%   -0.01%     
==========================================
  Files         276      276              
  Lines       35517    35520       +3     
==========================================
+ Hits        27424    27425       +1     
- Misses       7009     7010       +1     
- Partials     1084     1085       +1     
Flag Coverage Δ
unittests 77.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/check_casting_expression.go 96.73% <100.00%> (ø)
runtime/sema/check_force_expression.go 91.30% <100.00%> (+0.39%) ⬆️
runtime/sema/type.go 88.19% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b96c6...8a51b83. Read the comment docs.

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 57b96c6
The command go test ./... -run=XXX -bench=. -shuffle=on -count N was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeFungibleTokenTransfer-21.49ms ±20%1.38ms ± 4%~(p=0.805 n=7+7)
RuntimeResourceDictionaryValues-218.0ms ± 5%18.1ms ± 3%~(p=0.710 n=7+7)
RuntimeStorageWriteCached-2163µs ± 4%160µs ± 3%~(p=0.053 n=7+7)
ParseDeploy/byte_array-237.7ms ± 4%37.5ms ± 4%~(p=1.000 n=7+7)
ParseArray-224.5ms ± 2%24.4ms ± 1%~(p=0.620 n=7+7)
QualifiedIdentifierCreation/Three_levels-2179ns ± 1%183ns ± 5%~(p=0.149 n=6+7)
CheckContractInterfaceFungibleTokenConformance-2182µs ± 6%185µs ± 6%~(p=0.318 n=7+7)
ContractInterfaceFungibleToken-254.1µs ± 4%53.8µs ± 2%~(p=0.902 n=7+7)
NewInterpreter/new_interpreter-21.31µs ± 3%1.32µs ± 5%~(p=0.924 n=6+7)
NewInterpreter/new_sub-interpreter-22.46µs ± 5%2.48µs ± 6%~(p=0.902 n=7+7)
InterpretRecursionFib-23.07ms ± 1%3.02ms ± 2%−1.64%(p=0.011 n=7+7)
ParseFungibleToken-2511µs ± 2%500µs ± 3%−2.24%(p=0.026 n=7+7)
ParseDeploy/decode_hex-21.66ms ± 2%1.60ms ± 1%−3.24%(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-23.60ns ± 2%3.45ns ± 2%−4.18%(p=0.001 n=7+7)
ParseInfix-226.6µs ± 3%24.8µs ± 2%−6.90%(p=0.001 n=7+7)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2233kB ± 0%233kB ± 0%~(p=0.731 n=6+7)
RuntimeResourceDictionaryValues-24.34MB ± 0%4.34MB ± 0%~(p=0.318 n=7+7)
RuntimeStorageWriteCached-283.7kB ± 0%83.7kB ± 0%~(p=1.000 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-265.7kB ± 0%65.7kB ± 0%~(all equal)
ContractInterfaceFungibleToken-226.5kB ± 0%26.5kB ± 0%~(p=0.192 n=7+7)
NewInterpreter/new_interpreter-2720B ± 0%720B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.11kB ± 0%1.11kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.245 n=6+7)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.40k ± 0%4.40k ± 0%~(p=0.385 n=6+7)
RuntimeResourceDictionaryValues-2108k ± 0%108k ± 0%~(p=0.991 n=7+7)
RuntimeStorageWriteCached-21.42k ± 0%1.42k ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2457 ± 0%457 ± 0%~(all equal)
NewInterpreter/new_interpreter-211.0 ± 0%11.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-232.0 ± 0%32.0 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
 

@turbolent turbolent merged commit f938a53 into master Nov 26, 2021
@turbolent turbolent deleted the bastian/disable-hints-by-default branch November 26, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants