-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable existing hints if linting is disabled #1275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense; I also don't think it makes sense to report hints when linting is not enabled.
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
==========================================
- Coverage 77.21% 77.21% -0.01%
==========================================
Files 276 276
Lines 35517 35520 +3
==========================================
+ Hits 27424 27425 +1
- Misses 7009 7010 +1
- Partials 1084 1085 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 57b96c6 Results
|
Depends on #1072
Description
Just like disabling the new hint in #1072, also disable the existing hints when linting is disabled (the default).
master
branchFiles changed
in the Github PR explorer