Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-apply "Remove receiver type from function type" #1272

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

turbolent
Copy link
Member

Closes #1199


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up!

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit f7654a8
The command go test ./... -run=XXX -bench=. -shuffle=on -count N was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
ContractInterfaceFungibleToken-250.1µs ± 2%53.0µs ± 3%+5.77%(p=0.001 n=7+7)
QualifiedIdentifierCreation/Three_levels-2177ns ± 1%184ns ± 1%+3.62%(p=0.001 n=7+6)
RuntimeFungibleTokenTransfer-21.50ms ±24%1.60ms ±20%~(p=0.259 n=7+7)
RuntimeResourceDictionaryValues-218.1ms ± 2%18.1ms ± 2%~(p=0.805 n=7+7)
RuntimeStorageWriteCached-2156µs ± 1%155µs ± 1%~(p=0.537 n=5+6)
ParseArray-226.0ms ± 3%25.8ms ± 0%~(p=0.731 n=7+6)
ParseInfix-227.2µs ± 2%26.9µs ± 2%~(p=0.165 n=7+7)
ParseFungibleToken-2524µs ± 1%527µs ± 2%~(p=0.295 n=7+6)
ParseDeploy/decode_hex-21.61ms ± 2%1.61ms ± 2%~(p=0.945 n=7+6)
QualifiedIdentifierCreation/One_level-23.59ns ± 3%3.66ns ± 4%~(p=0.165 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2182µs ± 5%184µs ± 2%~(p=0.128 n=7+7)
NewInterpreter/new_interpreter-21.28µs ± 3%1.28µs ± 4%~(p=0.805 n=7+7)
NewInterpreter/new_sub-interpreter-22.36µs ± 4%2.41µs ± 6%~(p=0.175 n=7+7)
InterpretRecursionFib-22.96ms ± 4%2.94ms ± 2%~(p=0.710 n=7+7)
ParseDeploy/byte_array-238.9ms ± 3%38.0ms ± 1%−2.24%(p=0.017 n=7+7)
 
alloc/opdelta
RuntimeStorageWriteCached-283.7kB ± 0%83.7kB ± 0%~(p=0.294 n=6+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
NewInterpreter/new_interpreter-2680B ± 0%680B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.06kB ± 0%1.06kB ± 0%~(all equal)
InterpretRecursionFib-21.21MB ± 0%1.21MB ± 0%~(all equal)
RuntimeResourceDictionaryValues-24.34MB ± 0%4.34MB ± 0%−0.02%(p=0.001 n=7+6)
RuntimeFungibleTokenTransfer-2233kB ± 0%231kB ± 0%−0.74%(p=0.001 n=7+6)
ContractInterfaceFungibleToken-226.7kB ± 0%26.5kB ± 0%−0.90%(p=0.001 n=7+7)
CheckContractInterfaceFungibleTokenConformance-266.4kB ± 0%65.7kB ± 0%−1.06%(p=0.008 n=6+7)
 
allocs/opdelta
RuntimeStorageWriteCached-21.42k ± 0%1.42k ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
NewInterpreter/new_interpreter-211.0 ± 0%11.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-231.0 ± 0%31.0 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
RuntimeResourceDictionaryValues-2108k ± 0%108k ± 0%−0.00%(p=0.000 n=7+6)
ContractInterfaceFungibleToken-2458 ± 0%457 ± 0%−0.22%(p=0.001 n=7+7)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%−0.37%(p=0.001 n=7+7)
RuntimeFungibleTokenTransfer-24.42k ± 0%4.40k ± 0%−0.62%(p=0.001 n=7+7)
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert temporary fix #1196 added for backward compatibility
2 participants