Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dependencies in contributing doc, plus gitignore. #1270

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

robert-e-davidson3
Copy link
Contributor

Description

I added a section describing the requirements to build and test cadence. Aside from go, wabt is also needed.

I also added some paths to .gitignore since they were generated when I ran make build or make test.

Notes:

  • I didn't create an issue. Do I need to?
  • Not sure which label(s) to use.

@robert-e-davidson3 robert-e-davidson3 added the Documentation Improvements or additions to documentation label Nov 22, 2021
@github-actions
Copy link

github-actions bot commented Nov 22, 2021

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 056cce3
The command go test ./... -run=XXX -bench=. -shuffle=on -count N was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeFungibleTokenTransfer-21.29ms ± 3%1.57ms ±18%+21.89%(p=0.001 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2170µs ± 2%178µs ± 7%+4.99%(p=0.011 n=7+7)
RuntimeResourceDictionaryValues-216.8ms ± 3%17.4ms ± 3%+4.04%(p=0.002 n=6+7)
RuntimeStorageWriteCached-2168µs ±45%143µs ± 2%~(p=0.456 n=7+7)
ParseArray-224.1ms ± 3%23.5ms ± 4%~(p=0.073 n=7+7)
ParseInfix-225.2µs ± 1%25.2µs ± 2%~(p=0.710 n=7+7)
ParseFungibleToken-2493µs ± 1%485µs ± 3%~(p=0.073 n=6+7)
ParseDeploy/byte_array-235.5ms ± 2%35.3ms ± 1%~(p=0.259 n=7+7)
QualifiedIdentifierCreation/One_level-23.35ns ± 3%3.30ns ± 0%~(p=0.300 n=7+7)
QualifiedIdentifierCreation/Three_levels-2164ns ± 1%164ns ± 1%~(p=0.836 n=6+7)
InterpretRecursionFib-22.78ms ± 2%2.80ms ± 4%~(p=0.902 n=7+7)
NewInterpreter/new_interpreter-21.21µs ± 2%1.21µs ± 5%~(p=1.000 n=7+7)
NewInterpreter/new_sub-interpreter-22.17µs ± 2%2.17µs ± 1%~(p=0.945 n=7+6)
ParseDeploy/decode_hex-21.50ms ± 5%1.44ms ± 1%−4.17%(p=0.001 n=7+6)
ContractInterfaceFungibleToken-251.1µs ± 1%48.5µs ± 2%−5.23%(p=0.001 n=6+7)
 
alloc/opdelta
RuntimeStorageWriteCached-283.7kB ± 0%83.7kB ± 0%~(p=0.832 n=6+7)
RuntimeResourceDictionaryValues-24.34MB ± 0%4.34MB ± 0%~(p=0.779 n=7+7)
RuntimeFungibleTokenTransfer-2233kB ± 0%233kB ± 0%~(p=0.805 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-266.4kB ± 0%66.4kB ± 0%~(p=0.592 n=7+7)
ContractInterfaceFungibleToken-226.7kB ± 0%26.7kB ± 0%~(all equal)
InterpretRecursionFib-21.21MB ± 0%1.21MB ± 0%~(all equal)
NewInterpreter/new_interpreter-2680B ± 0%680B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.06kB ± 0%1.06kB ± 0%~(all equal)
 
allocs/opdelta
RuntimeStorageWriteCached-21.42k ± 0%1.42k ± 0%~(all equal)
RuntimeResourceDictionaryValues-2108k ± 0%108k ± 0%~(p=0.446 n=7+6)
RuntimeFungibleTokenTransfer-24.43k ± 0%4.42k ± 0%~(p=0.073 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
NewInterpreter/new_interpreter-211.0 ± 0%11.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-231.0 ± 0%31.0 ± 0%~(all equal)
 

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! First PR 🎉👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants