-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for casting storage ref to an invalid type #1243
Conversation
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit ad6895c Results
|
2fe0450
to
5b56d32
Compare
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
=======================================
Coverage 77.59% 77.59%
=======================================
Files 274 274
Lines 35232 35232
=======================================
Hits 27339 27339
Misses 6806 6806
Partials 1087 1087
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding a test for this 👍
Description
There were no tests for the following scenario:
T
in an accountauth AnyStruct
auth R
This was the only scenario that doesn't work if we do #1217 (there's a solution for it, I'll update the original git-issue with more context/info), but realized there were no test cases for this particular case (all tests were passing!)
master
branchFiles changed
in the Github PR explorer