Fix composite-typed argument passing #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit c4c1392 Results
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
=======================================
Coverage 77.53% 77.54%
=======================================
Files 274 274
Lines 35085 35083 -2
=======================================
Hits 27204 27204
+ Misses 6801 6799 -2
Partials 1080 1080
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SupunS
force-pushed
the
supun/arg-passing
branch
from
11f734c to
2e2c946
Compare
turbolent
approved these changes
Nov 15, 2021
| @@ -3817,7 +3817,11 @@ func (interpreter *Interpreter) GetContractComposite(contractLocation common.Add | |||
| return contractValue, nil | |||
| } | |||
|
|
|||
| func (interpreter *Interpreter) getCompositeType(location common.Location, qualifiedIdentifier string, typeID common.TypeID) (*sema.CompositeType, error) { | |||
| func (interpreter *Interpreter) GetCompositeType( | |||
Co-authored-by: Bastian Müller <[email protected]>
SupunS
force-pushed
the
supun/arg-passing
branch
from
11ba330 to
ef30e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes onflow/flow-emulator#94
Description
When composite typed values are passed in as arguments, always get the field type info from the type-definition.
masterbranchFiles changedin the Github PR explorer