-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve state decoding tool #1232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
+ Coverage 77.17% 77.41% +0.23%
==========================================
Files 279 273 -6
Lines 35791 34823 -968
==========================================
- Hits 27623 26957 -666
+ Misses 7081 6791 -290
+ Partials 1087 1075 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 141b10c Results
|
err := loadStorageKey(key, address, data, inter, slabStorage) | ||
var slabNotFoundErr *atree.SlabNotFoundError | ||
if errors.As(err, &slabNotFoundErr) { | ||
slabNotFoundErrCount++ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think atree.SlabNotFoundError
might not be returned from loadStorageKey
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loadStorageKey
calls StoredValue
on the decoded slab, which in turn might read more slabs (e.g. if it is an atree value like an array or dictionary). The decoded state might be corrupt, which might cause atree to load a slab which does not exist, resulting in a SlabNotFoundError
Co-authored-by: Supun Setunga <[email protected]>
Description
master
branchFiles changed
in the Github PR explorer