-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing types and conversion functions to cadence package #1224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you please also add tests?
Co-authored-by: Bastian Müller <[email protected]>
I added tests to |
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
- Coverage 77.46% 77.40% -0.06%
==========================================
Files 273 273
Lines 34764 34821 +57
==========================================
+ Hits 26929 26953 +24
- Misses 6760 6793 +33
Partials 1075 1075
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ah, I see, looks good! I had missed those, they didn't look like tests right away |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning this up!
Closes #1219
Description
These types were previously missing from the
cadence
package, but had equivalents insema
andinterpreter
. This fills in the missing types and adds encoding, decoding, import and export converters for them.master
branchFiles changed
in the Github PR explorer