Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container mutation tests for inserting functions into dictionaries #1215

Merged

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Nov 3, 2021

Description

Just like for arrays, check the insertion of various kinds of functions into dictionaries.

This was triggered by a report from @sideninja that insertion of functions into dictionaries is not working on Mainnet.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested review from dsainati1 and SupunS November 3, 2021 14:11
@turbolent turbolent self-assigned this Nov 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #1215 (6e064c5) into master (2b9ff0d) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
+ Coverage   76.91%   77.12%   +0.21%     
==========================================
  Files         272      272              
  Lines       33887    33910      +23     
==========================================
+ Hits        26065    26154      +89     
+ Misses       6724     6693      -31     
+ Partials     1098     1063      -35     
Flag Coverage Δ
unittests 77.12% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/conversion.go 95.12% <0.00%> (ø)
runtime/interpreter/value.go 82.33% <0.00%> (+1.50%) ⬆️
runtime/interpreter/primitivestatictype.go 74.29% <0.00%> (+1.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9ff0d...6e064c5. Read the comment docs.

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for adding this!

@turbolent turbolent merged commit 3003f80 into master Nov 4, 2021
@turbolent turbolent deleted the bastian/add-function-dictionary-container-mutation-tests branch November 4, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants