Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on marketplace design code sample #1207

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

javiermanzano
Copy link
Contributor

Description

There is a typo on marketplace sample documentation. Balance for the second account is not correct (it's working fine on the playground)


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@turbolent turbolent added the Documentation Improvements or additions to documentation label Nov 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1207 (ea5cd9d) into master (23a917f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1207   +/-   ##
=======================================
  Coverage   73.39%   73.39%           
=======================================
  Files         272      272           
  Lines       34603    34603           
=======================================
  Hits        25398    25398           
  Misses       8032     8032           
  Partials     1173     1173           
Flag Coverage Δ
unittests 73.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09e67f9...ea5cd9d. Read the comment docs.

@turbolent turbolent merged commit 2b9ff0d into onflow:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants