-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up types in cadence
package
#1204
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=======================================
Coverage 77.45% 77.46%
=======================================
Files 273 273
Lines 34766 34764 -2
=======================================
Hits 26929 26929
+ Misses 6762 6760 -2
Partials 1075 1075
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
While working on #1202 I also noticed that some primitive static types (namely |
@dsainati1 No, this is not intentional, they are missing. Good catch! |
96f18e5
to
2223bab
Compare
Description
While reviewing #1202 I noticed some tech debt
cadence.Function
tocadence.FunctionType
to be consistent with the naming for other types in the packagecadence.Variable
andcadence.ResourcePointer
. I don't know why they were theremaster
branchFiles changed
in the Github PR explorer