Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LS dependencies #1163

Merged
merged 10 commits into from
Dec 3, 2021
Merged

Update LS dependencies #1163

merged 10 commits into from
Dec 3, 2021

Conversation

devbugging
Copy link
Contributor

@devbugging devbugging commented Oct 5, 2021

Description

This PR updates language server dependencies needed for updating dependencies in the CLI, specifically it updates:

  • cadence v0.18.1-0.20210617175100-225316245130 -> v0.19.1
  • go SDK v0.20.0-alpha.1 -> v0.22.0
  • flow cli v0.28.4

It also implements all the API changes made in the dependencies.

WIP: After CLI is released and tagged, tag the new version here


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@devbugging devbugging self-assigned this Oct 5, 2021
@devbugging devbugging marked this pull request as draft October 5, 2021 16:32
@github-actions
Copy link

github-actions bot commented Nov 16, 2021

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 141b10c
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2179µs ± 1%190µs ± 4%+6.60%(p=0.003 n=5+7)
ParseInfix-225.6µs ± 2%26.7µs ± 3%+4.22%(p=0.005 n=7+7)
ParseFungibleToken-2493µs ± 2%511µs ± 1%+3.47%(p=0.001 n=7+6)
ParseArray-224.0ms ± 4%24.8ms ± 3%+3.34%(p=0.011 n=7+7)
QualifiedIdentifierCreation/One_level-23.48ns ± 3%3.58ns ± 3%+2.75%(p=0.038 n=7+7)
NewInterpreter/new_sub-interpreter-22.32µs ± 2%2.38µs ± 4%+2.68%(p=0.009 n=6+6)
ParseDeploy/decode_hex-21.59ms ± 2%1.62ms ± 1%+2.43%(p=0.022 n=7+6)
QualifiedIdentifierCreation/Three_levels-2181ns ± 2%184ns ± 3%+1.80%(p=0.038 n=7+7)
RuntimeFungibleTokenTransfer-21.61ms ±21%1.67ms ±21%~(p=0.620 n=7+7)
RuntimeResourceDictionaryValues-218.2ms ± 4%18.7ms ± 6%~(p=0.128 n=7+7)
ParseDeploy/byte_array-236.4ms ± 3%37.4ms ± 4%~(p=0.073 n=7+7)
ContractInterfaceFungibleToken-252.2µs ± 8%54.3µs ± 7%~(p=0.073 n=7+7)
InterpretRecursionFib-22.98ms ± 6%3.03ms ± 3%~(p=0.165 n=7+7)
NewInterpreter/new_interpreter-21.30µs ± 4%1.30µs ± 4%~(p=0.620 n=7+7)
 
alloc/opdelta
RuntimeResourceDictionaryValues-24.34MB ± 0%4.34MB ± 0%~(p=0.366 n=7+6)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
ContractInterfaceFungibleToken-226.5kB ± 0%26.5kB ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-265.7kB ± 0%65.7kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.462 n=7+7)
NewInterpreter/new_interpreter-2720B ± 0%720B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.11kB ± 0%1.11kB ± 0%~(all equal)
RuntimeFungibleTokenTransfer-2238kB ± 0%238kB ± 0%−0.01%(p=0.035 n=6+7)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.53k ± 0%4.53k ± 0%~(p=0.670 n=7+7)
RuntimeResourceDictionaryValues-2108k ± 0%108k ± 0%~(p=0.333 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
ContractInterfaceFungibleToken-2457 ± 0%457 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
NewInterpreter/new_interpreter-211.0 ± 0%11.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-232.0 ± 0%32.0 ± 0%~(all equal)
 

@devbugging devbugging marked this pull request as ready for review November 16, 2021 10:45
@turbolent
Copy link
Member

@sideninja Do we still need to get this in? Happy to sync

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #1163 (08b685f) into master (141b10c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         279      279           
  Lines       35791    35791           
=======================================
  Hits        27623    27623           
  Misses       7081     7081           
  Partials     1087     1087           
Flag Coverage Δ
unittests 77.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141b10c...08b685f. Read the comment docs.

@turbolent
Copy link
Member

Updated further to the latest Cadence release v0.20.2 and the latest Flow CLI release v0.29.0

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cadence-related changes look good, thank you!

@turbolent turbolent merged commit b3c99f7 into master Dec 3, 2021
@turbolent turbolent deleted the gregor/update-cadence branch December 3, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants