Add static type sanity check for imported values #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/container-static-types #1048 +/- ##
==================================================================
+ Coverage 73.47% 73.57% +0.09%
==================================================================
Files 271 271
Lines 34003 34024 +21
==================================================================
+ Hits 24984 25033 +49
+ Misses 7882 7853 -29
- Partials 1137 1138 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6 tasks
turbolent
approved these changes
Jul 5, 2021
| @@ -715,12 +715,49 @@ func validateArgumentParams( | |||
| } | |||
| } | |||
|
|
|||
| // Ensure static type info is available for all values | |||
| interpreter.InspectValue(arg, func(value interpreter.Value) bool { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #870
Description
Add a check to ensure the inferred type for arrays/ditionaries is always present and is valid.
Ideally, this check should never fail. But this is more of a second-line of defense, to make sure no value is passed into a program without type info / with incorrect type info.
masterbranchFiles changedin the Github PR explorer