Infer array and dictionary static types from expected type during import #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Base automatically changed from
bastian/array-static-type
to
feature/container-static-types
June 30, 2021 15:44
turbolent
force-pushed
the
bastian/container-value-import-type-inference
branch
from
7ab11b0 to
ff69f6a
Compare
turbolent
changed the base branch from
feature/container-static-types
to
bastian/finish-storage-v5
turbolent
force-pushed
the
bastian/container-value-import-type-inference
branch
from
ff69f6a to
66fc4e9
Compare
6 tasks
Base automatically changed from
bastian/finish-storage-v5
to
feature/container-static-types
July 2, 2021 04:12
SupunS
approved these changes
Jul 2, 2021
| @@ -92,13 +92,22 @@ func (t InterfaceStaticType) Equal(other StaticType) bool { | |||
| otherInterfaceType.QualifiedIdentifier == t.QualifiedIdentifier | |||
| } | |||
|
|
|||
| // ArrayStaticType | |||
|
|
|||
| type ArrayStaticType interface { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #870
Description
When importing values, provide the expected type (e.g. the parameter type for a script argument) to the import function, and use it to determine the static type for array values and dictionary values.
masterbranchFiles changedin the Github PR explorer