Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add walker for values #1037

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Add walker for values #1037

merged 1 commit into from
Jun 30, 2021

Conversation

turbolent
Copy link
Member

Work towards #870

Description

Add a function to walk an interpreter.Value, WalkValue, similar to ast.Walk.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #1037 (b3f5e1e) into master (ffe9881) will decrease coverage by 0.01%.
The diff coverage is 55.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   75.55%   75.53%   -0.02%     
==========================================
  Files         268      270       +2     
  Lines       32999    33028      +29     
==========================================
+ Hits        24932    24948      +16     
- Misses       6944     6956      +12     
- Partials     1123     1124       +1     
Flag Coverage Δ
unittests 75.53% <55.17%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/block.go 65.71% <0.00%> (-8.48%) ⬇️
runtime/interpreter/deployed_contract.go 28.57% <0.00%> (-3.43%) ⬇️
runtime/interpreter/function.go 56.00% <ø> (ø)
runtime/interpreter/walk.go 66.66% <66.66%> (ø)
runtime/interpreter/inspect.go 75.00% <75.00%> (ø)
runtime/interpreter/value.go 77.49% <75.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe9881...b3f5e1e. Read the comment docs.

@turbolent turbolent force-pushed the bastian/value-walker branch from c3bfd29 to b3f5e1e Compare June 29, 2021 21:13
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent merged commit b123dc9 into master Jun 30, 2021
@turbolent turbolent deleted the bastian/value-walker branch June 30, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants