Add encoding/decoding dictionary static type info #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
turbolent
reviewed
Jun 29, 2021
|
@fxamacker Could you please also have a look at this PR? It changes the storage format to add static type information for dictionaries, the work is similar to your earlier work on optimizing encoding and decoding. Thank you! |
SupunS
force-pushed
the
supun/dictionary-static-type
branch
2 times, most recently
from
92cd227 to
6a2d1bc
Compare
SupunS
force-pushed
the
supun/array-static-type
branch
from
9f54635 to
2b2c1ff
Compare
SupunS
force-pushed
the
supun/dictionary-static-type
branch
from
6a2d1bc to
afe7ae8
Compare
…adence into supun/dictionary-static-type
Base automatically changed from
supun/array-static-type
to
feature/container-static-types
June 30, 2021 17:44
turbolent
reviewed
Jun 30, 2021
Comment on lines
-913
to
+915
| // Encode keys (as array) at array index encodedDictionaryValueKeysFieldKey | ||
| // (1) Encode dictionary static type at array index encodedDictionaryValueTypeFieldKey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #870
masterbranchFiles changedin the Github PR explorer