Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the Cadence documentation generator #1003

Merged
merged 5 commits into from
Jun 15, 2021

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 13, 2021

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Documentation Improvements or additions to documentation label Jun 13, 2021
@SupunS SupunS self-assigned this Jun 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #1003 (433b131) into master (4d0bc74) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   75.55%   75.58%   +0.02%     
==========================================
  Files         267      267              
  Lines       32796    32885      +89     
==========================================
+ Hits        24780    24856      +76     
- Misses       6898     6908      +10     
- Partials     1118     1121       +3     
Flag Coverage Δ
unittests 75.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/convertValues.go 83.80% <0.00%> (-0.35%) ⬇️
runtime/runtime.go 86.88% <0.00%> (-0.34%) ⬇️
runtime/sema/checker.go 90.00% <0.00%> (-0.01%) ⬇️
runtime/interpreter/value.go 77.43% <0.00%> (-0.01%) ⬇️
runtime/sema/function_activations.go 93.93% <0.00%> (ø)
runtime/common/declarationkind_string.go 33.33% <0.00%> (ø)
runtime/sema/check_function.go 99.55% <0.00%> (+<0.01%) ⬆️
values.go 69.20% <0.00%> (+0.31%) ⬆️
runtime/common/declarationkind.go 75.96% <0.00%> (+0.96%) ⬆️
types.go 57.72% <0.00%> (+1.62%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0bc74...433b131. Read the comment docs.

Co-authored-by: Joshua Hannan <[email protected]>

### Markdown Support
Standard Markdown format is supported in doc-comments, with a bit of Cadence flavour.
This means, any Markdown syntax used within the comments would be honoured and rendered like a standard Markdown snippet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +54 to +59
/// This is the description of the function. This function adds two values.
///
/// @param a: First integer value to add
/// @param b: Second integer value to add
/// @return Addition of the two arguments `a` and `b`
///
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite like this mix 👍

pub fun add(a: Int, b: Int): Int {
}
```
- When documenting function parameters and return type, avoid mixing parameter/return-type documentations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Bastian Müller <[email protected]>
@SupunS SupunS force-pushed the supun/doc-gen-docs branch from 1481837 to 433b131 Compare June 15, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants