Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ByteSize() to TypeInfo interface #328

Closed
wants to merge 1 commit into from

Conversation

fxamacker
Copy link
Member

Updates #292

Description

This PR adds ByteSize() function in TypeInfo interface, which is used to compute extra data size of inlined registers.

Context

Inlined registers are treated as element and its encoded size must be known at runtime to enforce slab size limits. Since inlined registers are root slabs with extra data, encoded extra data size needs to be computed.


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker added the breaking change changes to API that can break programs using Atree's API label Jul 18, 2023
@fxamacker fxamacker self-assigned this Jul 18, 2023
@fxamacker
Copy link
Member Author

Postponing merge (for now) because I found a better approach and am looking into it to see if it works out.

@fxamacker
Copy link
Member Author

Closing this PR because I found a better approach.

@fxamacker fxamacker closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change changes to API that can break programs using Atree's API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants