Implement crop processor #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 75.63% 75.81% +0.17%
==========================================
Files 21 21
Lines 2266 2299 +33
==========================================
+ Hits 1714 1743 +29
- Misses 552 556 +4Continue to review full report at Codecov.
|
raxityo
reviewed
Mar 27, 2017
| /// | ||
| /// The target size will be automatically calculated with a reasonable behavior. | ||
| /// For example, when you have an image size of `CGSize(width: 100, height: 100)`, | ||
| /// and a target size of `CGSize(width: 100, height: 100)`, with a (0.0, 0.0) anchor (top-left), |
There was a problem hiding this comment.
I think we want to say:
a target size of
CGSize(width: 20, height: 20)
There was a problem hiding this comment.
Yes you are definitely right! Thanks for pointing it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.