Fix Jitter #6
Merged
Fix Jitter #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smoothed out the jitter by including full margin in height calculations
FIXED JITTER. must set child height state if children changed.
| @@ -37,6 +37,8 @@ | |||
| }, | |||
| "license": "Apache 2.0", | |||
| "dependencies": { | |||
| "element-size": "^1.1.1", | |||
| "lodash": "^3.9.3", | |||
There was a problem hiding this comment.
What is the lodash dependancy for?
There was a problem hiding this comment.
I added it in because the build was complaining about it not being there. I don't remember where it was being used though.
There was a problem hiding this comment.
Ah looks like I use it in the example and didn't add it to the dependancy. Can you move it to the devDependencies since it's not a requirement of the actual component?
There was a problem hiding this comment.
Ah I see, I'll fix that.
|
Thanks for the pull request! Sorry it has taken me so long to get around to reviewing it. |
Formatting cleanup for pr to original master repo.
|
Added those changes into the pr. |
|
lgtm 👍 |
|
Released as v0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The height calculation now includes margin. Also added a check to see if the children height changes so scroll calculations are good for the new children.