Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding a custom CSS class to the DateRangePicker #147

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

andywer
Copy link
Contributor

@andywer andywer commented Jul 13, 2016

For custom styling purposes it is highly desirable to be able to add a custom CSS class to the DateRangePicker.

I saw that the classnames module is in the dependencies, but it seems to not be used, so I didn't use it either for this purpose. In case you want to throw classnames out...

@AlanFoster
Copy link
Member

Good catch; We currently depend on classnames within our [examples file](https://github.com/onefinestay/react-daterange-picker/blob/master/example/components/code-snippet.jsx#L50] - but we do not rely on it within the main calendar component.

I may be worth moving the classnames dependency into our devDependencies though

@@ -62,6 +63,7 @@ const DateRangePicker = React.createClass({
return {
bemNamespace: null,
bemBlock: 'DateRangePicker',
className: '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andywer
Copy link
Contributor Author

andywer commented Jul 18, 2016

Ready to merge when you are 😉

@andywer
Copy link
Contributor Author

andywer commented Aug 1, 2016

Any objections?

@AlanFoster
Copy link
Member

Thanks for the PR 👍

@AlanFoster AlanFoster merged commit f0ace85 into onefinestay:master Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants