-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 support 🚀 #855
Merged
Merged
IPv6 support 🚀 #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onedr0p
reviewed
Jul 17, 2023
- name: Verify cluster CIDR is ipv4 OR ipv6
when: not bootstrap_ipv6_enabled | default(false)
ansible.builtin.assert:
that: bootstrap_cluster_cidr is ansible.utils.ipv4 or bootstrap_cluster_cidr is ansible.utils.ipv6
success_msg: Cluster CIDR {{ bootstrap_cluster_cidr }} is valid.
fail_msg: Cluster CIDR {{ bootstrap_cluster_cidr }} is invalid.
- name: Verify service CIDR is ipv4 OR ipv6
when: not bootstrap_ipv6_enabled | default(false)
ansible.builtin.assert:
that: bootstrap_service_cidr is ansible.utils.ipv4 or bootstrap_service_cidr is ansible.utils.ipv6
success_msg: Service CIDR {{ bootstrap_service_cidr }} is valid.
fail_msg: Service CIDR {{ bootstrap_service_cidr }} is invalid.
- name: Verify cluster CIDR is ipv4 AND ipv6
when: bootstrap_ipv6_enabled | default(false)
ansible.builtin.assert:
that: >
(
bootstrap_cluster_cidr.split(',')[0] is ansible.utils.ipv4 or
bootstrap_cluster_cidr.split(',')[1] is ansible.utils.ipv4
) and (
bootstrap_cluster_cidr.split(',')[1] is ansible.utils.ipv6 or
bootstrap_cluster_cidr.split(',')[0] is ansible.utils.ipv6
)
success_msg: Cluster CIDR {{ bootstrap_cluster_cidr }} is valid.
fail_msg: Cluster CIDR {{ bootstrap_cluster_cidr }} is invalid.
- name: Verify service CIDR is ipv4 AND ipv6
when: bootstrap_ipv6_enabled | default(false)
ansible.builtin.assert:
that: >
(
bootstrap_service_cidr.split(',')[0] is ansible.utils.ipv4 or
bootstrap_service_cidr.split(',')[1] is ansible.utils.ipv4
) and (
bootstrap_service_cidr.split(',')[1] is ansible.utils.ipv6 or
bootstrap_service_cidr.split(',')[0] is ansible.utils.ipv6
)
success_msg: Cluster CIDR {{ bootstrap_service_cidr }} is valid.
fail_msg: Cluster CIDR {{ bootstrap_service_cidr }} is invalid. |
onedr0p
reviewed
Jul 17, 2023
onedr0p
reviewed
Jul 17, 2023
onedr0p
requested changes
Jul 17, 2023
bootstrap/templates/ansible/playbooks/templates/custom-cilium-helmchart.yaml.j2.j2
Outdated
Show resolved
Hide resolved
bootstrap/templates/ansible/playbooks/templates/custom-coredns-helmchart.yaml.j2.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Devin Buhl <[email protected]>
Co-authored-by: Devin Buhl <[email protected]>
Ansible will connect over IPv4
onedr0p
requested changes
Jul 17, 2023
bootstrap/templates/ansible/playbooks/templates/custom-cilium-helmchart.yaml.j2.j2
Outdated
Show resolved
Hide resolved
bootstrap/templates/ansible/playbooks/templates/custom-cilium-helmchart.yaml.j2.j2
Outdated
Show resolved
Hide resolved
bootstrap/templates/ansible/playbooks/templates/custom-coredns-helmchart.yaml.j2.j2
Show resolved
Hide resolved
bootstrap/templates/ansible/inventory/group_vars/worker/main.yaml.j2
Outdated
Show resolved
Hide resolved
bootstrap/templates/ansible/inventory/group_vars/master/main.yaml.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Devin Buhl <[email protected]>
onedr0p
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.