Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support remotely-managed cloudflare tunnels #1378

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

jfroy
Copy link
Contributor

@jfroy jfroy commented Mar 20, 2024

No description provided.

@github-actions github-actions bot added the area/bootstrap Changes made in the bootstrap directory label Mar 20, 2024
@onedr0p
Copy link
Owner

onedr0p commented Mar 20, 2024

I wonder if there's a better way to name locally vs remotely managed tunnels? It might be because it's early but this confused me a bit at first 😅

Maybe cli-created vs web-created?

@jfroy
Copy link
Contributor Author

jfroy commented Mar 20, 2024

I wonder if there's a better way to name locally vs remotely managed tunnels? It might be because it's early but this confused me a bit at first 😅

Maybe cli-created vs web-created?

I borrowed those terms straight from cloudflare for consistency. https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/get-started/. But based on that document as well, could use "CLI" vs "dashboard".

@mrueg
Copy link
Contributor

mrueg commented Mar 20, 2024

Alternatively, we could use https://github.com/adyanth/cloudflare-operator which would allow changes after the cluster has been bootstrapped.

@jfroy
Copy link
Contributor Author

jfroy commented Mar 20, 2024

Alternatively, we could use https://github.com/adyanth/cloudflare-operator which would allow changes after the cluster has been bootstrapped.

Technically the only thing that's required to use a remotely-managed tunnel is to set the TUNNEL_TOKEN env var. If it is set to a non-empty value, cloudflared will use it, otherwise it will continue and use the credentials file. So all someone would need to do is edit the secret. We would need to edit the PR to not have the template conditionals in the secret definition and in the helm release.

https://github.com/cloudflare/cloudflared/blob/master/cmd/cloudflared/tunnel/subcommands.go#L656

@onedr0p
Copy link
Owner

onedr0p commented Mar 20, 2024

Alternatively, we could use https://github.com/adyanth/cloudflare-operator which would allow changes after the cluster has been bootstrapped.

That would be nice but the release and commit history on it doesn't give me confidence that it's well supported.

@onedr0p onedr0p merged commit 13f4f99 into onedr0p:main Mar 25, 2024
4 checks passed
@onedr0p
Copy link
Owner

onedr0p commented Apr 10, 2024

@jfroy I am getting some support requests that make this a bit confusing to people. I may just go back to CLI-only created and managed tunnels.

@jfroy jfroy deleted the cloudflare-remote branch April 12, 2024 11:55
@jfroy
Copy link
Contributor Author

jfroy commented Apr 12, 2024

@jfroy I am getting some support requests that make this a bit confusing to people. I may just go back to CLI-only created and managed tunnels.

Totally fair. I wasn't comfortable with yet more secrets in plaintext under my home directory, so I went with a dashboard tunnel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Changes made in the bootstrap directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants