Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IPv6 cidr to CiliumLoadBalancerIPPool resource #1146

Closed
wants to merge 3 commits into from

Conversation

haraldkoch
Copy link
Contributor

If the config variable bootstrap_ipv6_enabled is set, the CiliumLoadBalancerIPPool is not added to the cluster.

This update changes the bootstrap logic to include a NODE_CIDR_V6 value in the CiliumLoadBalancerIPPool, derived from the key bootstrap_node_cidr in the initial bootstrap/vars/config.yaml file.

It's a barebones change - there is no error checking or the like.

@github-actions github-actions bot added area/kubernetes Changes made in the kubernetes directory area/bootstrap Changes made in the bootstrap directory labels Jan 14, 2024
@onedr0p
Copy link
Owner

onedr0p commented Jan 14, 2024

This logic will also need to be added to the k3s cilium config, or maybe I should just remove this file and have Flux apply it? There might not be any reason to have the L2 config applied at cluster bootstrap.

The Cilium L2 config is now only being applied by Flux

@onedr0p
Copy link
Owner

onedr0p commented Jan 14, 2024

It does look like the tests are failing or need to be updated for ipv4,ipv6 instead of ipv4 in bootstrap_node_cidr

https://github.com/onedr0p/flux-cluster-template/blob/main/.github/tests/config-ipv6.yaml

@onedr0p onedr0p marked this pull request as draft January 14, 2024 02:09
@onedr0p
Copy link
Owner

onedr0p commented Jan 14, 2024

@haraldkoch I think it might be good to circle back on this when the upstream blockers in #1148 are implemented by Cilium or it might give people the wrong impression that this is supported.

@onedr0p onedr0p closed this Jan 14, 2024
@haraldkoch
Copy link
Contributor Author

Ooof. you're correct - if ND doesn't work, there's no point.

The part that fails to add the IPv4 CiliumLoadBalancerIPPool if IPv6 is enabled still needs fixing, though. All my services were until I fixed that part! I can create a different / separate PR.

@onedr0p
Copy link
Owner

onedr0p commented Jan 14, 2024

Feel free to open a new one or reopen this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Changes made in the bootstrap directory area/kubernetes Changes made in the kubernetes directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants