src: attr: quantization refactor (part 3) #2746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:cpu-x64
|
make test |
mgouicem
approved these changes
Feb 25, 2025
dzarukin
force-pushed
the
dzarukin/quant_styling
branch
from
cf9b2da to
4478b31
Compare
Fix dispatching to jit gemm implementation. Previous logic would update the variable which would skip entire verbose verification function.
dzarukin
force-pushed
the
dzarukin/quant_styling
branch
from
4478b31 to
e444113
Compare
sgeor255
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the finishing part of quantization refactor that beautifies skip_mask values for scales and zero-points and introduces a single class for both of them with ability to extend one over the other.