-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generic: sycl: Inner Product FWD #2214
base: main
Are you sure you want to change the base?
Conversation
@@ -392,16 +392,16 @@ struct cudnn_matmul_lt_exec_t final : public cudnn_matmul_lt_base_exec_t { | |||
memory_tracking::names::key_matmul_dst_in_acc_dt) | |||
: xpu::sycl::interop_memory_arg_t< | |||
::sycl::access::mode::read_write>(); | |||
auto arg_block_a_scratch = params->source_size_ != 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the changes in this file are fixing bugs? If so, should we consider adding more tests to catch them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
If so, should we consider adding more tests to catch them?
From what I can tell, this file should be covering all the possible combinations, and I do see the case for which this was failing (i.e A = S8, ab format, B = S8, ba format, and C = S32, ab format), but maybe others with a better understanding could chime in, maybe @ShanoToni ?
Edit: Link to the aforementioned file - https://github.com/oneapi-src/oneDNN/blob/main/tests/benchdnn/inputs/matmul/test_matmul_int8
@AD2605 you should probably update https://github.com/oneapi-src/oneDNN/blob/main/src/gpu/generic/sycl/README.md to mention inner product is supported :) |
@sgeor255 , updated the documentation |
3bd9d00
to
c5d66f1
Compare
Description
Implements the forward pass of the inner product for the generic sycl backend with support for different post-ops and data types