cpu: aarch64: brgemm: Fix unimplemented conditions for brgemm #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@Shreyas-fuj can you please have a look. Thanks. |
theComputeKid
changed the title
@theComputeKid, @Ryo-not-rio, I tested from my end it seems fine to me, thanks. |
Change-Id: I3be1901c6209a9ace14eda073c90f4c4098d228d
theComputeKid
approved these changes
Oct 4, 2024
Radu2k
approved these changes
Oct 4, 2024
github-actions
bot
added
the
platform:cpu-aarch64
Radu2k
pushed a commit
to Radu2k/oneDNN
that referenced
this pull request
Dec 2, 2024
Merged
Radu2k
pushed a commit
to Radu2k/oneDNN
that referenced
this pull request
Dec 2, 2024
Radu2k
pushed a commit
to Radu2k/oneDNN
that referenced
this pull request
Dec 2, 2024
mgouicem
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing asserts in brgemm accidentally flipped the validation conditions for brgemm, causing brgemm to go to the gemm:jit implementation instead of brg:sve_256 implementation. This is a fix for that issue.
Bug fixes
The issue can be reproduced by running the
./tests/benchdnn/benchdnn --matmul 2048x479:479x1024. The observed behaviour is gemm:jit being used whereas this fix should cause brg:sve_256 to be run.