Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix to include path for ArmPL builds. #1111

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

nSircombe
Copy link
Contributor

Description

In order to find the right include path for ArmPL, CMake searches for blas.h,
which ArmPL provides. However, depending on the enviroment, it is possible for
CMake to pick up blas.h from a different BLAS library, such as OpenBLAS, and
choose an incorrect include path as a result.

This PR updates blas.cmake to look for armpl.h when setting the BLAS
inlude path instead,

Checklist

Code-change submissions

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally?
  • [N/A] Have you formatted the code using clang-format?
    Note: changes are restricted to the build system, and have no material impact
    on functioning of the library under normal conditions.

Bug fixes

  • [N/A] Have you added relevant regression tests?
    Note: changes are restricted to the build system, and have no material impact
    on functioning of the library under normal conditions.
  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?

@nSircombe
Copy link
Contributor Author

This PR addresses #1100.

Copy link
Contributor

@igorsafo igorsafo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, thanks!

@igorsafo igorsafo added this to the v2.4 milestone Jul 1, 2021
@igorsafo igorsafo merged commit 3b28c52 into oneapi-src:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants