Skip to content

Commit

Permalink
gpu: nvidia: Added missing bf16 threshold for softmax
Browse files Browse the repository at this point in the history
ShanoToni authored and dzarukin committed Nov 1, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
1 parent 188ae7f commit e9d0fdb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/benchdnn/softmax/softmax.cpp
Original file line number Diff line number Diff line change
@@ -232,7 +232,7 @@ void setup_cmp(compare::compare_t &cmp, const prb_t *prb, data_kind_t kind,
const float trh_coeff_bwd = (prb->dir & FLAG_FWD) ? 1.f : 4.f;
const float trh_f32 = trh_coeff_log * trh_coeff_bwd * trh_coeff_f32
* epsilon_dt(trh_dt);
#if DNNL_AARCH64 || defined(DNNL_SYCL_HIP)
#if DNNL_AARCH64 || defined(DNNL_SYCL_HIP) || defined(DNNL_SYCL_CUDA)
// MIOpen and ACL softmax accumulate in F16, but oneDNN now expects accumulation in
// F32, this partially reverts 6727bbe8. For more information on ACL softmax, see
// https://github.com/oneapi-src/oneDNN/issues/1819

0 comments on commit e9d0fdb

Please sign in to comment.