Remove deprecated target variant dispatch from oneMKL sample #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyfe1
approved these changes
Sep 9, 2024
|
@andrewtbarker Can you submit a PR to the |
@jimmytwei Not really. The development branch already has the most important change here. The ticket was reported to us based on the master branch, so fix should be done there? |
7 tasks
|
Made #2482 into development branch, but it does not really fix the issue that was reported. To fix that we need to either merge this PR or update the master branch. |
jimmytwei
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Removes deprecated
omp target dispatchconstruct from oneAPI samples.External Dependencies
No new dependencies.
Type of change
How Has This Been Tested?
Tested locally on linux PVC.