This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
[U] optimize style selection logic #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artefaritaKuniklo
added a commit
that referenced
this pull request
Mar 19, 2024
* [+] Add navigation bar * [F] Fix typo * [U] Update License * [F] Fix padding * [U] Update uniguide url * [F] Fix mobile display * [S] better navigation bar * [R] Revert "[S] better navigation bar" This reverts commit cbd9154. * [U] Update logo * [F] Fix padding * [U] Add toggle button for dark/light mode * [F] Fix dark mode toggle button * [U] optimize style selection logic (#1) * [U] optimize logic of confirming current site * [U] support different languages of Uniguide * [U] alter navbar style --------- Co-authored-by: sauricat <[email protected]> Co-authored-by: Elihuso Quigley <[email protected]> Co-authored-by: Linzh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further work:
Maybe we can add an extra
.Siteattribute to give a unique value for each site regardless of site language and title. Nonetheless, it may not be an issue worth considering currently.