Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to unlock review mode #478

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

calvinlu3
Copy link
Contributor

@calvinlu3 calvinlu3 commented Nov 19, 2024

Issue

Some reviewers may leave the review page open even though they are away from keyboard for a while. This makes it so that the review page is locked.

Changes

Allow another user to force the current reviewer out, but give a warning.

image

@calvinlu3 calvinlu3 added the fix Fix tag for release label Nov 19, 2024
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinlu3 calvinlu3 merged commit 84a4d28 into oncokb:rc Nov 19, 2024
2 checks passed
@calvinlu3 calvinlu3 deleted the unlock-review-page branch November 19, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix tag for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants