Do not show needs curation for categorical alterations #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinlu3
requested changes
Aug 15, 2024
| @@ -22,6 +24,10 @@ const NotCuratableBadge: React.FunctionComponent<INotCuratableBadgeProps> = ({ m | |||
| const mutationStrings: [string[], string[]] = [[], []]; | |||
| for (const name of mutationName.split(',')) { | |||
| const trimmedName = name.trim(); | |||
| if (Object.values(CategoricalAlterationType).includes(parseAlterationName(trimmedName)[0].alteration as CategoricalAlterationType)) { | |||
There was a problem hiding this comment.
Currently, for non-string mutations, only Oncogenic Mutations is not curatable. See util method: isMutationEffectCuratable. Maybe move the excludedMutations arrays out to a constants, so you can use it here?
There was a problem hiding this comment.
Ah gotcha, looking at the method, I could just use it directly
zhx828
changed the title
jfkonecn
pushed a commit
to jfkonecn/oncokb-transcript
that referenced
this pull request
Aug 29, 2024
* do not show needs curation for categorical alterations * address comments
jfkonecn
pushed a commit
to jfkonecn/oncokb-transcript
that referenced
this pull request
Sep 17, 2024
* do not show needs curation for categorical alterations * address comments
jfkonecn
pushed a commit
to jfkonecn/oncokb-transcript
that referenced
this pull request
Sep 23, 2024
* do not show needs curation for categorical alterations * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/oncokb/oncokb-pipeline/issues/517