Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore main type options in cancer select #409

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

calvinlu3
Copy link
Contributor

@calvinlu3 calvinlu3 commented Aug 12, 2024

fixes https://github.com/oncokb/oncokb-pipeline/issues/514

Reverted some checks in this PR: https://github.com/oncokb/oncokb-transcript/pull/374/files#diff-a91f33c921fa62dc9aff971740373a2300bdf1de7fb0f893ddb8b6076ce37cb4

The issue was that main type tumors have level=0. Since 0 is a falsey value, it caused a bug.

@calvinlu3 calvinlu3 requested a review from jfkonecn August 12, 2024 23:34
@calvinlu3 calvinlu3 merged commit 0f1c103 into oncokb:rc Aug 13, 2024
2 checks passed
@calvinlu3 calvinlu3 deleted the fix/cancer-select branch August 13, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants