Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gene type submission #396

Merged

Conversation

jfkonecn
Copy link

No description provided.

@jfkonecn jfkonecn requested a review from zhx828 July 31, 2024 13:38
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfkonecn jfkonecn merged commit 3fe71f4 into oncokb:feature/submit-to-core Jul 31, 2024
0 of 2 checks passed
@jfkonecn jfkonecn deleted the feature/gene-type-change branch July 31, 2024 17:00
jfkonecn added a commit that referenced this pull request Oct 24, 2024
* Added core submission logic

* Added Save Gene Logic (#385)

* Added name changes to review logic (#393)

* Added name change to core submission logic

* Added missing unit tests

* Addessed PR comments

* Removed unneeded uuid

* added comments to collectUUIDs function

* Added gene type submission (#396)

* Can now delete evidences (#398)

* fixed logging in

* fixed build errors

* updated drugs mapping

* updated drugs mapping

* Add releaseGene param when saving gene data to core

* Update to allow save all genes

* Fix excludedRCTs

* Add method to undo gene release

* Use reviewed content only (#430)

* Use reviewed content only

* Ignore if in review added state

* Save Genes now checks if added

* Delete parent node if added field is true

* Fixed build

* don't save undefined

* Addressed PR comments

* Addressed PR comments

* Feature/fix submit to core (#439)

* Handle when Instant json element is a json object

The completedDate in the DB could be ISO 8601 string, or json object. I think this has to do with the recent spring boot upgrade, but I can't find the specific version of the change. I will handle both scenarios for now

* Textarea in review mode should fit text content (#427)

* Update pom version

* Fix reject cancer type name review (#428)

* Add reference to oncokb sop alteration nomenclature in add mutation modal helper (#432)

* Update pom version

* Avoid fetching management info repeatedly

* Do not rerender the side bar when loading session

The getSession is an async method which updates the loading status.

* Fix drug code not selectable (#435)

* Bump actions to latest version (#438)

* resize text area when input changes (#440)

* add sorting by firebase index (#443)

* Delete mutation/tumor/treatment as last step to avoid stale index (#444)

* Review no longer removes data for core submission

* Added comments to useLastReviewOnly

* Add children review paths

* Fixed approve all

* Fixed UI tests

* Fixed UI tests

* break in middle of word to fix collapsible title overlfow (#442)

* Change searchEntities to readHandler instead of updateHandler (#445)

* Fixed submit all

* Fixed submission bug

* Fixed data validation tool (#447)

* Allow curating mutation summary (#433)

* Fixed submit all

* Fixed tests

* Fixed gene type submissions

* Removed last review check inside getevidences and gene type

* Added mutation summary

---------

Co-authored-by: Hongxin <[email protected]>
Co-authored-by: Hongxin <[email protected]>
Co-authored-by: Calvin Lu <[email protected]>
Co-authored-by: oncokb-bot <[email protected]>
Co-authored-by: bprize15 <[email protected]>

* Added Vus submissions to core (#456)

* Make core API call non-blocking (#454)

* Handle when Instant json element is a json object

The completedDate in the DB could be ISO 8601 string, or json object. I think this has to do with the recent spring boot upgrade, but I can't find the specific version of the change. I will handle both scenarios for now

* Textarea in review mode should fit text content (#427)

* Update pom version

* Fix reject cancer type name review (#428)

* Add reference to oncokb sop alteration nomenclature in add mutation modal helper (#432)

* Update pom version

* Avoid fetching management info repeatedly

* Do not rerender the side bar when loading session

The getSession is an async method which updates the loading status.

* Fix drug code not selectable (#435)

* Bump actions to latest version (#438)

* resize text area when input changes (#440)

* add sorting by firebase index (#443)

* Delete mutation/tumor/treatment as last step to avoid stale index (#444)

* break in middle of word to fix collapsible title overlfow (#442)

* Change searchEntities to readHandler instead of updateHandler (#445)

* Fixed data validation tool (#447)

* Allow curating mutation summary (#433)

* Parse protein change case insensitive (#441)

* Fix adding CDx biomarker association (#450)

* use firebase properties directly in backend (#451)

* fix references tab (#452)

* Added Heap (#448)

* Added Heap

* Updated CSP

* Reduce width so sidebar does not go offscren (#446)

* allow comma in mutation name when transcripts present (#453)

* allow comma in mutation name when transcripts present

* add missing colon

* rename transcripts to reference genomes

* Make core API call non-blocking

* Add tests for stale indices check (#455)

* Added loading icon when review is accepted

* Update setup-java action

* Update pom version

* Put feature flag in app config

* Now showing loading icon on accept all

---------

Co-authored-by: Hongxin <[email protected]>
Co-authored-by: Hongxin <[email protected]>
Co-authored-by: Calvin Lu <[email protected]>
Co-authored-by: oncokb-bot <[email protected]>
Co-authored-by: bprize15 <[email protected]>

---------

Co-authored-by: Hongxin <[email protected]>
Co-authored-by: Hongxin <[email protected]>
Co-authored-by: Calvin Lu <[email protected]>
Co-authored-by: oncokb-bot <[email protected]>
Co-authored-by: bprize15 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants