Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make is_primitive_list more precise #944

Merged
merged 2 commits into from
May 26, 2022
Merged

Make is_primitive_list more precise #944

merged 2 commits into from
May 26, 2022

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented May 24, 2022

Closes #939.

pixelb
pixelb reviewed May 24, 2022
View reviewed changes
@Jasha10 Jasha10 marked this pull request as draft May 24, 2022 23:05
@Jasha10 Jasha10 requested a review from pixelb May 26, 2022 09:37
@Jasha10 Jasha10 marked this pull request as ready for review May 26, 2022 10:14
@Jasha10 Jasha10 requested a review from jieru-hu May 26, 2022 10:14
pixelb
pixelb approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.
Thank you

@Jasha10 Jasha10 merged commit c16f2f9 into omry:master May 26, 2022
@Jasha10 Jasha10 deleted the closes939 branch May 26, 2022 14:04
@Jasha10
Copy link
Collaborator Author

Jasha10 commented May 27, 2022 •
edited
Loading

TODO:

@Jasha10 Jasha10 mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelb pixelb pixelb approved these changes

@jieru-hu jieru-hu Awaiting requested review from jieru-hu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BC breaking when for "allow_objects=True" flag
2 participants
@Jasha10 @pixelb