Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oc.deprecated #679

Merged
merged 3 commits into from
Apr 16, 2021
Merged

oc.deprecated #679

merged 3 commits into from
Apr 16, 2021

Conversation

omry
Copy link
Owner

@omry omry commented Apr 15, 2021 •
edited
Loading

  1. Refactor docs, moving resolvers to a dedicated page.
  2. Adding support for oc.deprecated.

Most of changed lines here are from the docs refactor.
Try to go over it anyway and let me know if you have any feedback.

Closes #681.

@omry omry requested review from odelalleau and Jasha10 April 15, 2021 02:22
@omry omry force-pushed the oc.deprecated branch 2 times, most recently from ec84378 to 65598ab Compare April 15, 2021 06:55
odelalleau
odelalleau requested changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@odelalleau odelalleau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of small things

Edit: Oh, also missing a news item?

docs/source/custom_resolvers.rst Show resolved Hide resolved
docs/source/usage.rst Outdated Show resolved Hide resolved
docs/source/usage.rst Outdated Show resolved Hide resolved
docs/source/usage.rst Outdated Show resolved Hide resolved
omegaconf/_impl.py Outdated Show resolved Hide resolved
omegaconf/resolvers/oc/__init__.py Outdated Show resolved Hide resolved
omegaconf/resolvers/oc/__init__.py Outdated Show resolved Hide resolved
omegaconf/resolvers/oc/__init__.py Outdated Show resolved Hide resolved
tests/interpolation/built_in_resolvers/test_oc_deprecated.py Outdated Show resolved Hide resolved
docs/source/custom_resolvers.rst Outdated Show resolved Hide resolved
odelalleau
odelalleau requested changes Apr 15, 2021
View reviewed changes
docs/source/custom_resolvers.rst Outdated Show resolved Hide resolved
docs/source/custom_resolvers.rst Outdated Show resolved Hide resolved
odelalleau
odelalleau requested changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing changes I had suggested

docs/source/custom_resolvers.rst Outdated Show resolved Hide resolved
docs/source/custom_resolvers.rst Show resolved Hide resolved
@omry
Copy link
Owner Author

omry commented Apr 15, 2021

I think I got everything.

odelalleau
odelalleau approved these changes Apr 16, 2021
View reviewed changes
Copy link
Collaborator

@odelalleau odelalleau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! There was a doc error due to my "fix" (which fixed something but broke another) => I pushed the fix directly, should be good to merge once all green

@omry omry merged commit dad564e into master Apr 16, 2021
@omry omry deleted the oc.deprecated branch April 16, 2021 02:26
@omry omry added this to the OmegaConf 2.1 milestone Apr 16, 2021
This was referenced Apr 16, 2021
Merged
Closed
@odelalleau odelalleau mentioned this pull request Nov 23, 2021
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasha10 Jasha10 Jasha10 left review comments

@odelalleau odelalleau odelalleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OmegaConf 2.1
Development

Successfully merging this pull request may close these issues.

Add oc.deprecated to enable deprecating config nodes
3 participants
@omry @odelalleau @Jasha10