Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed OmegaConf.select() with relative keys #656

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fixed OmegaConf.select() with relative keys #656

merged 1 commit into from
Apr 1, 2021

Conversation

omry
Copy link
Owner

@omry omry commented Apr 1, 2021 •
edited
Loading

I am not including a news fragment because relative interpolations are new in 2.1.

@omry omry requested a review from odelalleau April 1, 2021 18:22
@omry omry force-pushed the select_relative branch from 6d93b7d to ebffe92 Compare April 1, 2021 18:26
@omry omry force-pushed the select_relative branch from ebffe92 to 42f8d95 Compare April 1, 2021 18:29
@omry omry requested a review from Jasha10 April 1, 2021 19:30
omry
omry commented Apr 1, 2021
View reviewed changes
tests/test_select.py
param(
{"user@domain": 10, "foo": "${user@domain}"}, "foo", 10, id="user@domain"
),
# relative interpolations
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new tests starts here.

@omry omry mentioned this pull request Apr 1, 2021
Merged
Jasha10
Jasha10 approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@omry omry merged commit 2c48e60 into master Apr 1, 2021
@omry omry deleted the select_relative branch April 1, 2021 22:04
odelalleau
odelalleau reviewed Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@omry omry mentioned this pull request Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odelalleau odelalleau odelalleau left review comments

@Jasha10 Jasha10 Jasha10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omry @odelalleau @Jasha10